Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the client/server protocol handshake so the client can negotiate (downgrade) to the server’s reported protocol minor version instead of rejecting older servers.
Changes:
- Removed the client-side
isCompatible()compatibility table and related rejection logic. - Updated
Client::handleHelloto always respond withhelloBackMinor = minorfrom the server hello. - Tweaked hello/hello-back log verbosity and messaging.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/lib/client/Client.h |
Removes the isCompatible() declaration as part of simplifying handshake logic. |
src/lib/client/Client.cpp |
Removes compatibility table + rejection path; always negotiates the server’s protocol minor in handleHello. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
✅ Merge build was successful. |
https://symless.atlassian.net/browse/S1-2094